<html>
<head><meta charset="utf-8"><title>gimli re-landing · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html">gimli re-landing</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="205298335"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205298335" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205298335">(Jul 28 2020 at 22:29)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I can doing some profiling of the gimli re-landing if that would be helpful. Do we have a PR where I can easily obtain the new code, with all the relevant improvements?</p>



<a name="205298566"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205298566" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205298566">(Jul 28 2020 at 22:31)</a>:</h4>
<p>Yes</p>



<a name="205298572"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205298572" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205298572">(Jul 28 2020 at 22:31)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/74682">https://github.com/rust-lang/rust/pull/74682</a></p>



<a name="205298652"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205298652" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205298652">(Jul 28 2020 at 22:32)</a>:</h4>
<p>I've done some profiling myself and we have <a href="https://github.com/rust-lang/rust/pull/74887">https://github.com/rust-lang/rust/pull/74887</a> up from me, and <a href="https://github.com/rust-lang/rust/pull/74807">https://github.com/rust-lang/rust/pull/74807</a> as well</p>



<a name="205298669"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205298669" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205298669">(Jul 28 2020 at 22:32)</a>:</h4>
<p>I have not examined the latter but the first brings us from 19.7% to 18.6% on helloworld locally</p>



<a name="205298729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205298729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205298729">(Jul 28 2020 at 22:33)</a>:</h4>
<p><span class="user-mention" data-user-id="120989">@njn</span> my guess is that there's no silver bullet here, fwiw</p>



<a name="205298854"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205298854" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205298854">(Jul 28 2020 at 22:34)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/74887">#74887</a> does bring down the attribute loading from +732 queries to +126, which is nice -- not too big a bump in real perf though I suspect</p>



<a name="205299478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299478">(Jul 28 2020 at 22:42)</a>:</h4>
<p>I tried applying <a href="https://github.com/rust-lang/rust/commit/f7bc182c506bdbc790d6d8a547a1ea2f3de5e165.diff">https://github.com/rust-lang/rust/commit/f7bc182c506bdbc790d6d8a547a1ea2f3de5e165.diff</a> with <code>patch</code>, I'm having trouble with <code>library/backtrace</code></p>



<a name="205299517"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299517" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299517">(Jul 28 2020 at 22:42)</a>:</h4>
<p>oh it's a submodule</p>



<a name="205299521"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299521" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299521">(Jul 28 2020 at 22:42)</a>:</h4>
<p>Running <code>x.py check</code> I get some Python <code>KeyError: u'library/backtrace</code></p>



<a name="205299533"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299533" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299533">(Jul 28 2020 at 22:43)</a>:</h4>
<p>ah</p>



<a name="205299536"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299536" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299536">(Jul 28 2020 at 22:43)</a>:</h4>
<div class="codehilite"><pre><span></span><code>+[submodule &quot;src/backtrace&quot;]
+   path = library/backtrace
+   url = https://github.com/rust-lang/backtrace-rs.git
</code></pre></div>



<a name="205299542"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299542" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299542">(Jul 28 2020 at 22:43)</a>:</h4>
<p>that looks wrong</p>



<a name="205299548"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299548" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299548">(Jul 28 2020 at 22:43)</a>:</h4>
<p>I would try s/src/library on that or something like that</p>



<a name="205299550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299550">(Jul 28 2020 at 22:43)</a>:</h4>
<p>ok, thanks</p>



<a name="205299559"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299559" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299559">(Jul 28 2020 at 22:43)</a>:</h4>
<p>and some <code>git submodule update --init --recursive</code> can't hurt</p>



<a name="205299578"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299578" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299578">(Jul 28 2020 at 22:43)</a>:</h4>
<p>worst case, clone it manually and stick it in that dir :)</p>



<a name="205299685"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299685" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299685">(Jul 28 2020 at 22:44)</a>:</h4>
<p><code>KeyError: u'library/backtrace'</code>, grr</p>



<a name="205299751"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299751" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299751">(Jul 28 2020 at 22:45)</a>:</h4>
<p>I manually cloned into library/backtrace, same error</p>



<a name="205299999"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205299999" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205299999">(Jul 28 2020 at 22:48)</a>:</h4>
<p>Hm any context for that?</p>



<a name="205300028"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205300028" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205300028">(Jul 28 2020 at 22:48)</a>:</h4>
<div class="codehilite"><pre><span></span><code>Updating only changed submodules
Traceback (most recent call last):
  File &quot;./x.py&quot;, line 11, in &lt;module&gt;
    bootstrap.main()
  File &quot;/home/njn/moz/rust1/src/bootstrap/bootstrap.py&quot;, line 1009, in main
    bootstrap(help_triggered)
  File &quot;/home/njn/moz/rust1/src/bootstrap/bootstrap.py&quot;, line 969, in bootstrap
    build.update_submodules()
  File &quot;/home/njn/moz/rust1/src/bootstrap/bootstrap.py&quot;, line 845, in update_submodules
    self.update_submodule(module[0], module[1], recorded_submodules)
  File &quot;/home/njn/moz/rust1/src/bootstrap/bootstrap.py&quot;, line 785, in update_submodule
    if recorded_submodules[module] == checked_out:
KeyError: u&#39;library/backtrace&#39;
</code></pre></div>



<a name="205300076"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205300076" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205300076">(Jul 28 2020 at 22:49)</a>:</h4>
<p>Ok, don't know why it's doing that. Try disabling auto updating submodules in config.toml</p>



<a name="205300176"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205300176" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205300176">(Jul 28 2020 at 22:50)</a>:</h4>
<p>Presumably something or other is out of sync</p>



<a name="205300418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/gimli%20re-landing/near/205300418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/gimli.20re-landing.html#205300418">(Jul 28 2020 at 22:54)</a>:</h4>
<p>Also you can try rm -rf library/backtrace and then retrying a git submodule update I guess</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>